Adds functions for creating a PDF PAdES and adding a signature [SFEQS-966] #1
Conversation
| void generatePadesFile( | ||
| File originalPdf, | ||
| OutputStream outputStream, | ||
| String signatureFieldId |
There was a problem hiding this comment.
what if we have multiple signature fields?
There was a problem hiding this comment.
No problem, you have to indicate the signatureFieldId. If the signature already exists on that signatureFieldId an exception is thrown!
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(Utility.class); | ||
|
|
||
| static ByteRange getByteRange(DSSDocument documentToSign, String signatureFieldId) |
There was a problem hiding this comment.
can you add some comments clarifying what's happening here?
There was a problem hiding this comment.
surely. I will try to clarify as best I can!
| @@ -0,0 +1,36 @@ | |||
| package it.pagopa.dss; | |||
There was a problem hiding this comment.
Still lack addSignatureToPadesFile coverage!
There was a problem hiding this comment.
Added new test and coverage report!
| ); | ||
|
|
||
| assertThat(signedByte).isEqualTo(signatureValue); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
I don't know the Java framework but if any exceptions occurs here it looks like it's silently swallowed and the asertion would not be called, maybe it's better to avoid to catch it?
There was a problem hiding this comment.
Yes, test fails anyway. However it is best to add a throws Exception.
There was a problem hiding this comment.
Why it fails anyway? Because no assertion was called?
There was a problem hiding this comment.
You're right, i thought that without a call to assertThat the test failed instead it doesn't. I fixed by adding throws Exception on test function.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
|
| //converting the file into a DSS document (from dss library) | ||
| DSSDocument documentToSign = new FileDocument(originalPdf); | ||
|
|
||
| //initialization of PAdES parameters |
There was a problem hiding this comment.
this kind of comments add little value (are self-evident). instead I'd try to elaborate more ie. on what
parameters.setGenerateTBSWithoutCertificate(true);
does and why it must be set to true.
Co-authored-by: Danilo Spinelli <[email protected]>
Co-authored-by: Danilo Spinelli <[email protected]>
|
This PR implement:
generatePadesFileaddSignatureToPadesFile