Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-800] feat: Add new get creditor institution name API #38

Merged
merged 5 commits into from
Mar 15, 2024
Merged

[VAS-800] feat: Add new get creditor institution name API #38

merged 5 commits into from
Mar 15, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Mar 7, 2024 •
edited
Loading

List of Changes

  • added new API to retrieve creditor institution business names from creditor insitution tax codes
  • added unit tests
  • added javadoc
  • fixed test package location in order to compute code coverage correctly
  • fixed README

Motivation and Context

Added new API to retrieve creditor information info usefull for backoffice

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella requested a review from a team as a code owner March 7, 2024 14:14
@gioelemella gioelemella force-pushed the VAS-800-add-retrieve-ci-names-api branch from 19ef8a8 to 29f3da7 Compare March 14, 2024 16:29
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gioelemella gioelemella merged commit 720d6f2 into main Mar 15, 2024
8 of 10 checks passed
@gioelemella gioelemella deleted the VAS-800-add-retrieve-ci-names-api branch March 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

Assignees

@gioelemella gioelemella

Labels
size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @jacopocarlini