Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-912] fix: Retrieve segregation code API #46

Merged
merged 17 commits into from
May 30, 2024
Merged

[VAS-912] fix: Retrieve segregation code API #46

merged 17 commits into from
May 30, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented May 20, 2024 •
edited
Loading

List of Changes

  • removed useless parameters service and showUsedCodes
  • updated logic to retrieve only valid segregation codes:
    • excluded PagoPA reserved codes
    • excluded all codes that are already used by the target creditor insitution as segregation or application codes
    • for specific creditor insitutions dedicated code pool
  • added new API GET /creditorinstitutions/stations/{station-code} to retrieve all creditor insitutions that can be associated to a station
  • updated unit tests
  • updated openapi configuration
  • updated openapi

Motivation and Context

VAS#1060

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added bug Something isn't working minor Semantic Version: minor change versioning labels May 20, 2024
@gioelemella gioelemella marked this pull request as ready for review May 20, 2024 15:31
@gioelemella gioelemella requested a review from a team as a code owner May 20, 2024 15:31
jacopocarlini
jacopocarlini requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok 👍 , but resolve the code smells please

@jacopocarlini
Copy link
Contributor

jacopocarlini commented May 21, 2024 •
edited
Loading

it's ok, but we can't merge before this PR.

@jacopocarlini
Copy link
Contributor

@gioelemella you can merge this PR

@gioelemella gioelemella force-pushed the VAS-912-fix-segregation-code branch from 42c267d to 307241a Compare May 28, 2024 09:36
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gioelemella gioelemella merged commit bec3ffe into main May 30, 2024
4 checks passed
@gioelemella gioelemella deleted the VAS-912-fix-segregation-code branch May 30, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

Assignees

@gioelemella gioelemella

Labels
bug Something isn't working minor Semantic Version: minor change versioning size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gioelemella @jacopocarlini @pagopa-github-bot