Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing mapping to new model #51

Merged
merged 5 commits into from
May 31, 2024
Merged

fixing mapping to new model #51

merged 5 commits into from
May 31, 2024

Conversation

FedericoRuzzier
Copy link
Contributor

List of Changes

Fixing model to iban list

Motivation and Context

Needed to maintain BO standard

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier added the bug Something isn't working label May 31, 2024
@FedericoRuzzier FedericoRuzzier requested a review from a team as a code owner May 31, 2024 15:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@FedericoRuzzier FedericoRuzzier merged commit b4efa53 into main May 31, 2024
4 checks passed
@FedericoRuzzier FedericoRuzzier deleted the fix-iban-list-model branch May 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

Assignees

@FedericoRuzzier FedericoRuzzier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedericoRuzzier @jacopocarlini @pagopa-github-bot