Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling #12

Merged
merged 10 commits into from
Aug 10, 2023
Merged

Exception handling #12

merged 10 commits into from
Aug 10, 2023

Conversation

pietro-tota
Copy link
Contributor

@pietro-tota pietro-tota commented Aug 9, 2023 •
edited
Loading

Depends on #11

List of Changes

  • Add exception handling logic to map applicative exceptions to proper http code
  • Add junit tests for code coverage

Motivation and Context

Those modifications are needed to properly map applicative exceptions to proper http codes

How Has This Been Tested?

Junit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pietro-tota pietro-tota requested a review from a team as a code owner August 9, 2023 11:12
@pietro-tota pietro-tota self-assigned this Aug 9, 2023
@pietro-tota pietro-tota changed the base branch from main to update-openapi August 9, 2023 11:21
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

giovanniberti
giovanniberti previously approved these changes Aug 9, 2023
View reviewed changes
Base automatically changed from update-openapi to main August 9, 2023 12:08
@pietro-tota pietro-tota dismissed giovanniberti’s stale review August 9, 2023 12:08

The base branch was changed.

@dpulls
Copy link

dpulls bot commented Aug 9, 2023

🎉 All dependencies have been resolved !

@pietro-tota
Merge branch 'main' into exception-handling
ffcb6a4 
# Conflicts:
#	src/main/kotlin/it/pagopa/ecommerce/helpdesk/services/EcommerceService.kt
@pietro-tota
fix: code smells
6f57670
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.8% 95.8% Coverage
0.1% 0.1% Duplication

@pietro-tota pietro-tota mentioned this pull request Aug 10, 2023
Merged
5 tasks
@pietro-tota pietro-tota merged commit da11529 into main Aug 10, 2023
5 checks passed
@pietro-tota pietro-tota deleted the exception-handling branch August 10, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovanniberti giovanniberti giovanniberti approved these changes

Assignees

@pietro-tota pietro-tota

Labels
size/large skip-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietro-tota @giovanniberti