Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): integrate ecommerce commons library #5

Merged
merged 14 commits into from
Aug 7, 2023

Conversation

pietro-tota
Copy link
Contributor

@pietro-tota pietro-tota commented Aug 3, 2023

List of Changes

Integrate ecommerce commons library.
Integration has been made through a custom sh script that perform pagopa-ecommerce-common remote repository checkout and build before starting gradle project build.
Then ecommerce common dependency is retrieved from local maven repository and project build proceed as defined into the gradle.build script file

Motivation and Context

Those modifications are needed in order to integrate ecommerce commons library with MongoDB documents used to retrieve transactions from eCommerce database

How Has This Been Tested?

Local build + docker build

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pietro-tota pietro-tota self-assigned this Aug 3, 2023
@pietro-tota pietro-tota requested a review from a team as a code owner August 3, 2023 16:30
Copy link
Contributor

@Fernando-Granato Fernando-Granato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments. Good job 🚀

Copy link
Contributor

@Fernando-Granato Fernando-Granato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pietro-tota and others added 7 commits August 4, 2023 14:29
Co-authored-by: Giovanni Berti <[email protected]>
Co-authored-by: Giovanni Berti <[email protected]>
Co-authored-by: Giovanni Berti <[email protected]>
Co-authored-by: Giovanni Berti <[email protected]>
Co-authored-by: Giovanni Berti <[email protected]>
Co-authored-by: Giovanni Berti <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pietro-tota and others added 2 commits August 4, 2023 18:53
Co-authored-by: Giovanni Berti <[email protected]>
Co-authored-by: Giovanni Berti <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@pietro-tota pietro-tota merged commit 08db07c into main Aug 7, 2023
2 of 3 checks passed
@pietro-tota pietro-tota deleted the CHK-1778-integrate-commons-library branch August 7, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants