Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOD-498] Call api config schema proxy #348

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[NOD-498] Call api config schema proxy #348

wants to merge 9 commits into from

Conversation

aomegax
Copy link
Contributor

@aomegax aomegax commented Feb 6, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This PR exceeds the recommended size of 450 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 450 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 28, 2024
View reviewed changes
src/integ-test/bdd-test/features/environment.py
@@ -77,7 +85,7 @@

db.closeConnection(conn)
headers = {'Host': 'api.dev.platform.pagopa.it:443'}
requests.get(utils.get_refresh_config_url(context),verify=False,headers=headers)
requests.get(utils.get_refresh_config_url(context), verify=False, headers=headers)

Check failure

Code scanning / CodeQL

Request without certificate validation High

This request may run without certificate validation because
it is disabled
Loading
.

Copilot Autofix AI 8 days ago

To fix the problem, we need to ensure that the request made on line 88 performs TLS certificate verification. This can be done by either removing the verify=False parameter, which will default to verify=True, or by explicitly setting verify=True. If there is a specific certificate that needs to be used, we can provide the path to the certificate file.

Steps to fix:

  1. Remove the verify=False parameter from the requests.get call on line 88.
  2. Ensure that the request still functions correctly with certificate verification enabled.
Suggested changeset 1
src/integ-test/bdd-test/features/environment.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/integ-test/bdd-test/features/environment.py b/src/integ-test/bdd-test/features/environment.py
--- a/src/integ-test/bdd-test/features/environment.py
+++ b/src/integ-test/bdd-test/features/environment.py
@@ -87,3 +87,3 @@
     headers = {'Host': 'api.dev.platform.pagopa.it:443'}  
-    requests.get(utils.get_refresh_config_url(context), verify=False, headers=headers)
+    requests.get(utils.get_refresh_config_url(context), headers=headers)
 
EOF
@@ -87,3 +87,3 @@
headers = {'Host': 'api.dev.platform.pagopa.it:443'}
requests.get(utils.get_refresh_config_url(context), verify=False, headers=headers)
requests.get(utils.get_refresh_config_url(context), headers=headers)

Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 450 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aomegax