checked that cart is in correct status. Added unit tests (#116)

Co-authored-by: giomella <[email protected]>
pagopa · Jan 8, 2024 · ca6e6ea · ca6e6ea
1 parent 29d1478
commit ca6e6ea
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/main/java/it/gov/pagopa/receipt/pdf/datastore/CartEventToReceipt.java b/src/main/java/it/gov/pagopa/receipt/pdf/datastore/CartEventToReceipt.java
@@ -79,6 +79,12 @@ public void run(
     ) {
         logger.info("[{}] function called at {}", context.getFunctionName(), LocalDateTime.now());
 
+        if (!cartForReceipt.getStatus().equals(CartStatusType.INSERTED)) {
+            logger.info("[{}] Cart with id {} not in status {}, this event will be skipped",
+                    context.getFunctionName(), cartForReceipt.getId(), CartStatusType.INSERTED);
+            return;
+        }
+
         if (cartForReceipt.getTotalNotice() != cartForReceipt.getCartPaymentId().size()) {
             logger.info("[{}] Not all items collected for cart with id {}, this event will be skipped",
                     context.getFunctionName(), cartForReceipt.getId());

diff --git a/src/test/java/it/gov/pagopa/receipt/pdf/datastore/CartEventToReceiptTest.java b/src/test/java/it/gov/pagopa/receipt/pdf/datastore/CartEventToReceiptTest.java
@@ -99,12 +99,27 @@ void cartEventToReceiptSuccess() {
     }
 
     @Test
-    void cartEventToReceiptSkip() {
+    void cartEventToReceiptSkipNotInStatusInserted() {
+        CartForReceipt cartForReceipt = getCartForReceipt();
+        cartForReceipt.setStatus(CartStatusType.FAILED);
+        assertDoesNotThrow(() -> sut.run(cartForReceipt, receiptDocumentdb, cartForReceiptDocumentdb, contextMock));
+
+        verify(bizEventToReceiptServiceMock, never()).getCartBizEvents(anyString());
+        verify(bizEventToReceiptServiceMock, never()).handleSaveReceipt(any());
+        verify(bizEventToReceiptServiceMock, never()).handleSendMessageToQueue(anyList(), any());
+
+        verify(receiptDocumentdb, never()).setValue(receiptCaptor.capture());
+        verify(cartForReceiptDocumentdb, never()).setValue(cartCaptor.capture());
+    }
+
+    @Test
+    void cartEventToReceiptSkipNotAllBizEventsCollected() {
         Set<String> bizEventIds = new HashSet<>();
         bizEventIds.add("id");
         CartForReceipt cartForReceipt = CartForReceipt.builder()
                 .id("123")
                 .totalNotice(2)
+                .status(CartStatusType.INSERTED)
                 .cartPaymentId(bizEventIds)
                 .build();
 
@@ -226,6 +241,7 @@ private CartForReceipt getCartForReceipt() {
         return CartForReceipt.builder()
                 .id("123")
                 .totalNotice(2)
+                .status(CartStatusType.INSERTED)
                 .cartPaymentId(bizEventIds)
                 .build();
     }