Generator emits cjs #1138
Generator emits cjs #1138
Conversation
ericanderson
force-pushed
the
ea.generate-cjs
branch
2 times, most recently
from
3dcf0ea to
cd1f78b
Compare
ericanderson
force-pushed
the
ea.generate-cjs
branch
from
a3ebb46 to
25d4163
Compare
| target: ScriptTarget.ES2020, | ||
| moduleResolution: ModuleResolutionKind.NodeNext, | ||
| resolvePackageJsonExports: true, |
There was a problem hiding this comment.
So you have to explicitly set this now because you're not specifying moduleResolution anymore?
More concretely, if module is CommonJS, then moduleResolution becomes node10, in which case, it wont look at exports by default. But if its ES2022, then technically you don't need to explicitly set that line right cuz it'll default on?
There was a problem hiding this comment.
Correct. So I want to be sure we are generating in a way that will work with Node16 so I turn this on.
| @@ -521,567 +521,567 @@ describe("generator", () => { | |||
| expect( | |||
| tweakedFilesForSnapshotConsistency(helper.getFiles()), | |||
| ).toMatchInlineSnapshot(` | |||
| { | |||
There was a problem hiding this comment.
is the main change here that now all the imports and exports have .js?
There was a problem hiding this comment.
Yes, it just simplified things and I wrote a test project to be sure it didn't matter
| @@ -42,21 +42,29 @@ export async function generatePackageJson(options: { | |||
| const packageJson = { | |||
| name: options.packageName, | |||
| version: options.packageVersion, | |||
| main: "./index.js", | |||
| types: "./index.d.ts", | |||
| main: "./cjs/index.js", | |||
There was a problem hiding this comment.
So are these two fields cjs now because node10 default looks at the main field?
| @@ -68,7 +68,7 @@ jobs: | |||
|
|
|||
| build: | |||
| name: Build and Test | |||
| timeout-minutes: 15 | |||
| timeout-minutes: 20 | |||
There was a problem hiding this comment.
Dang our tests taking long now
PR is broken into 3 commits and I recommend you review them by commit.
.jsextensions everywhere