Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: dockerfile from node:16.17.1-buster #430

Merged
merged 13 commits into from
Aug 1, 2024
Merged

Conversation

askonev
Copy link
Member

@askonev askonev commented Mar 26, 2024

node:16.17.1-buster

Running tests on the Karma and Jasmine frameworks

  • building a Dockerfile docker-build/docker-actions/Dockerfile in which we install the browser chrome:latest
  • running unit tests

@askonev askonev force-pushed the update/nodejs_v16.17.1 branch 7 times, most recently from 192170d to 5b5b405 Compare April 5, 2024 15:14
* ChromeHeadlessCustom mode
* apt install chrome
Copy link

@VitaliySerov VitaliySerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, a great job

Some minor changes

Also please check the action log:

https://github.com/palladium-tms/palladium-view/actions/runs/8572163899/job/23494065553?pr=430

It shows a lot of errors:

ERROR: 'NG0304: 'mat-error' is not a known element:
1. If 'mat-error' is an Angular component, then verify that it is part of this module.
2. If 'mat-error' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.'

but test seems working, better to fix those

.github/workflows/jasmine.yml Outdated Show resolved Hide resolved
docker-build/docker-actions/Dockerfile Outdated Show resolved Hide resolved
@askonev
Copy link
Member Author

askonev commented Jul 24, 2024

Looks very good, a great job

Some minor changes

Also please check the action log:

https://github.com/palladium-tms/palladium-view/actions/runs/8572163899/job/23494065553?pr=430

It shows a lot of errors:

ERROR: 'NG0304: 'mat-error' is not a known element:
1. If 'mat-error' is an Angular component, then verify that it is part of this module.
2. If 'mat-error' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to suppress this message.'

but test seems working, better to fix those

There was an error at startup

(node:19) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /palladium-view/node_modules/postcss/package.json.
Update this package.json to use a subpath pattern like "./*".

means that the postcss package is using an outdated way of specifying module exports in its package.json. This is a warning about future compatibility and does not usually affect the functionality of the package immediately but indicates that the package might need an update or configuration change in the future.

@askonev askonev force-pushed the update/nodejs_v16.17.1 branch 3 times, most recently from 6fb43d6 to c973340 Compare July 24, 2024 18:13
@askonev askonev force-pushed the update/nodejs_v16.17.1 branch 2 times, most recently from 6d4da31 to c70facc Compare July 30, 2024 12:42
@askonev askonev force-pushed the update/nodejs_v16.17.1 branch 2 times, most recently from 9d0d581 to 66361df Compare July 30, 2024 12:51
Copy link

@VitaliySerov VitaliySerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@askonev askonev merged commit 94366c5 into master Aug 1, 2024
5 checks passed
@askonev askonev deleted the update/nodejs_v16.17.1 branch August 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants