Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test without sqlalchemy-citext #2518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Sep 4, 2024

The last sqlalchemy-citext update was in 2021 and it has various compatibility issues.

SQLAlchemy now has CITEXT support.

@cjmayo cjmayo force-pushed the sqlalchemy-citext branch 3 times, most recently from 3468d1e to 6b49729 Compare September 4, 2024 18:39
@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 5, 2024

Whether this is case sensitive and whether we are testing it I am unsure:

@converts('Text', 'LargeBinary', 'Binary', 'CIText') # includes UnicodeText

@cjmayo
Copy link
Contributor Author

cjmayo commented Sep 7, 2024

Added a new commit - a wider problem - doesn't look like we have been testing SQLAlchemy 1.

With use_frozen_constraints constraints are generated by calling "pip
freeze" after the environment deps have been installed and before the
package dependencies are installed, thus constraints-sqlalchemy1.txt is
being ignored.

An idea of how to fix it in the added commit. At least this was all I could find. N.B. the formatted output of the GitHub Actions can truncate the list of pip installed packages.

@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 13, 2024

I'll rebase after #2540.

@cjmayo cjmayo force-pushed the sqlalchemy-citext branch 3 times, most recently from 76a1cf9 to 527daea Compare October 14, 2024 18:35
@cjmayo cjmayo marked this pull request as ready for review October 14, 2024 18:37
@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 14, 2024

Rebased.

The last sqlalchemy-citext update was in 2021 and it has various
compatibility issues.

SQLAlchemy now has CITEXT support.
@cjmayo cjmayo marked this pull request as ready for review October 15, 2024 18:26
@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 15, 2024

Finished experimenting.

@cjmayo cjmayo mentioned this pull request Oct 16, 2024
@samuelhwilliams
Copy link
Contributor

This looks sensible. Would you mind adding an entry in doc/changelog.rst under a new v2.0.0a2 heading please?

@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 27, 2024

Rebase this one? doc/changelog.rst has updated since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants