-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test without sqlalchemy-citext #2518
base: master
Are you sure you want to change the base?
Conversation
3468d1e
to
6b49729
Compare
Whether this is case sensitive and whether we are testing it I am unsure: flask-admin/flask_admin/contrib/sqla/form.py Line 323 in 5b069be
|
Added a new commit - a wider problem - doesn't look like we have been testing SQLAlchemy 1. With use_frozen_constraints constraints are generated by calling "pip An idea of how to fix it in the added commit. At least this was all I could find. N.B. the formatted output of the GitHub Actions can truncate the list of pip installed packages. |
I'll rebase after #2540. |
76a1cf9
to
527daea
Compare
Rebased. |
527daea
to
7b2dc1d
Compare
7b2dc1d
to
c68619a
Compare
The last sqlalchemy-citext update was in 2021 and it has various compatibility issues. SQLAlchemy now has CITEXT support.
c68619a
to
6c9e7c8
Compare
Finished experimenting. |
This looks sensible. Would you mind adding an entry in |
Rebase this one? |
The last sqlalchemy-citext update was in 2021 and it has various compatibility issues.
SQLAlchemy now has CITEXT support.