Add horizontal form support via BootstrapTheme #2532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjmayo
force-pushed
the
fix-lib-html
branch
3 times, most recently
from
821a8e1
to
7a36bc8
Compare
cjmayo
changed the title
cjmayo
changed the title
cjmayo
changed the title
Boostrap 4 renamed .control-label to .col-form-label. https://getbootstrap.com/docs/4.0/migration/#forms-1
|
I think this may need a bit more thought - if an app has multiple admin instances with different themes, these settings will get mixed up. Also, injecting the Flask-Admin theme as |
|
It's probably beyond my understanding of Admin and Views - obviously I could do a rename. I've split the fixes out anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow horizontal forms to be used as described in https://getbootstrap.com/docs/4.0/components/forms/#horizontal-form and used in #2368, although here no extra div is added to the template and it is configured from the Theme object. That was not quite so simple as there is also template rendering going on in form.widgets.RenderTemplateWidget - so this PR adds theme to current_app ???
Also.
Boostrap 4 renamed .control-label to .col-form-label.
https://getbootstrap.com/docs/4.0/migration/#forms-1
Closes #2368.