Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for python 3.8 #28

Merged
merged 1 commit into from
Jun 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ['3.12', '3.11', '3.10', '3.9', '3.8']
python: ['3.12', '3.11', '3.10', '3.9']
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
Expand Down
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Unreleased

- Drop support for Python 3.8.
- Support Flask-SQLAlchemy-Lite and plain SQLAlchemy, in addition to
Flask-SQLAlchemy. {pr}`26`
- Support multiple databases, and multiple metadata per database. {pr}`26`
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ classifiers = [
"Topic :: Database",
"Typing :: Typed",
]
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = [
"alembic>=1.13",
"flask>=3.0",
Expand Down Expand Up @@ -47,14 +47,14 @@ source = ["flask_alembic", "tests"]
source = ["src", "*/site-packages"]

[tool.mypy]
python_version = "3.8"
python_version = "3.9"
files = ["src/flask_alembic", "tests"]
show_error_codes = true
pretty = true
strict = true

[tool.pyright]
pythonVersion = "3.8"
pythonVersion = "3.9"
include = ["src/flask_alembic", "tests"]

[tool.ruff]
Expand Down
2 changes: 0 additions & 2 deletions requirements/tests-3.8.in

This file was deleted.

36 changes: 0 additions & 36 deletions requirements/tests-3.8.txt

This file was deleted.

4 changes: 2 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
import pytest
from flask import Flask
from flask.ctx import AppContext
from flask_sqlalchemy import SQLAlchemy
from flask_sqlalchemy_lite import SQLAlchemy

from flask_alembic import Alembic


@pytest.fixture
def app(request: pytest.FixtureRequest, tmp_path: Path) -> Flask:
app = Flask(request.module.__name__, root_path=os.fspath(tmp_path))
app.config["SQLALCHEMY_BINDS"] = {
app.config["SQLALCHEMY_ENGINES"] = {
"default": "sqlite://",
"other": "sqlite://",
}
Expand Down
6 changes: 1 addition & 5 deletions tests/test_fsa_lite.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@

import pytest
from flask import Flask
from flask_sqlalchemy_lite import SQLAlchemy
from sqlalchemy import create_engine
from sqlalchemy.orm import DeclarativeBase

from flask_alembic import Alembic

try:
from flask_sqlalchemy_lite import SQLAlchemy
except ImportError:
pytest.skip("flask_sqlalchemy_lite not available", allow_module_level=True)


@pytest.fixture
def app(app: Flask) -> Flask:
Expand Down
5 changes: 1 addition & 4 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
py3{12,11,10,9,8}
py3{12,11,10,9}
style
typing
docs
Expand All @@ -14,9 +14,6 @@ use_frozen_constraints = true
deps = -r requirements/tests.txt
commands = pytest -v --tb=short --basetemp={envtmpdir} {posargs}

[testenv:py38,py3.8]
deps = -r requirements/tests-3.8.txt

[testenv:style]
deps = pre-commit
skip_install = true
Expand Down