Remove deprecated Flask version attribute #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `flask.__version__` attr is deprecated and will be removed in Flask 3.1 version. This PR replaced this attr to `importlib.metadata.version`. We could remove the use of `pkg_resources` when we drop the Python 3.7 support.
greyli
force-pushed
the
fix-flask-version
branch
from
d967efe to
7e9bbae
Compare
greyli
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flask.__version__attr is deprecated and will be removed in the Flask 3.1 version. This PR replaced this attr toimportlib.metadata.version.We could remove the use of
pkg_resourceswhen we drop the Python 3.7 support.Fix: #229