New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Class-based rewrite #26

Open

joostdevries wants to merge 1 commit into pallets-eco:main from joostdevries:complete-rewrite

Collaborator

joostdevries commented May 11, 2016 •

edited

Loading

This is a proposed rewrite of this module. Basically it does two important things:

All logic is now class-based with a new, cleaner (IMO) API.
The worker now executes jobs with the app context.

I've created this rewrite because it drastically reduces the amount of code I have to write to get started and offers a cleaner API in my opinion.

Some stuff I'm still contemplating:

A way to make queues configurable in the app config (so you don't have to call create_queue)
Splitting this PR into two: one for the app-context-based worker and one for the new API (which will require a completely new major version or even different package name). Use app context when performing job #27

This is still work in progress but any input is greatly appreciated


          Complete rewrite

933a8a4

joostdevries mentioned this pull request

Use app context when performing job #27

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet