make calling_context more accurate #493
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in pallets-eco/flask-debugtoolbar#96, the current logic for generating the calling context often fails unnecessarily.
Specifically, when a project is structured like the following,
and the flask application is defined by
app = Flask(__name__)
inapp.py
, the calling context will be "unknown" if the query is issued from somewhere other thanapp.py
. This is because nowapp_path
isproject.app
but the relevant frame that issues the query might beproject.views
.The updated logic matches the frame with the top level package of the
app_path
.