-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give a UserWarning when Parameter is overriden by name #2397
Give a UserWarning when Parameter is overriden by name #2397
Conversation
This issue recently caused Chia a little grief when a short name collision was merged in - so I'm in support of this concept. |
8778b31
to
92be37c
Compare
cca0c46
to
b9f0ae3
Compare
The implementation proposed here checks every single time an option is used, whether its name has been used before. I moved this check to Additionally, the error message does not tell you which parameters. That could technically be done, but I'm not sure it's worth the extra time spent as it should be relatively straightforward to figure out. |
This adds a UserWarning when two parameters on one command have a name conflict. Very interested in thoughts and feedback.
Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.