Deduplicate --help option definition
#2563
Merged
+39
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeldycke
changed the title
--help option definition
kdeldycke
force-pushed
the
deduplicate-help-option
branch
2 times, most recently
from
37d3cc4
to
2045247
Compare
kdeldycke
force-pushed
the
deduplicate-help-option
branch
2 times, most recently
from
54f88b5
to
a9b0fb0
Compare
|
Conflicts have been resolved, this PR has been rebased on It is ready to merged back for the upcoming Click 8.2.x. |
|
@kdeldycke I like this! |
kdeldycke
force-pushed
the
deduplicate-help-option
branch
from
a9b0fb0
to
e436986
Compare
kdeldycke
force-pushed
the
deduplicate-help-option
branch
from
e436986
to
60fdea1
Compare
AndreasBackx
force-pushed
the
deduplicate-help-option
branch
from
60fdea1
to
9773a4d
Compare
|
Thanks @AndreasBackx for the merge! 🥳 |
|
Thank you for the PR @kdeldycke. Just trying to get through the backlog of issues and PR now so we can get some more movement on the project. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled upon an opportunity to deduplicate the code producing the default
--helpoption across Click code.Should I create a specific issue for that PR?
As this is just a refactor, I did not mentioned this into the changelog or docs.
The current tests demonstrates this PR does not introduce regressions.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.