Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate --help option definition #2563

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Jul 11, 2023

Just stumbled upon an opportunity to deduplicate the code producing the default --help option across Click code.

Should I create a specific issue for that PR?

As this is just a refactor, I did not mentioned this into the changelog or docs.

The current tests demonstrates this PR does not introduce regressions.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@kdeldycke kdeldycke changed the title Deduplicate help option definition Deduplicate --help option definition Jul 11, 2023
@kdeldycke kdeldycke marked this pull request as draft July 11, 2023 16:03
@kdeldycke kdeldycke force-pushed the deduplicate-help-option branch 2 times, most recently from 37d3cc4 to 2045247 Compare July 11, 2023 16:33
@kdeldycke kdeldycke marked this pull request as ready for review July 11, 2023 16:35
@kdeldycke kdeldycke force-pushed the deduplicate-help-option branch 2 times, most recently from 54f88b5 to a9b0fb0 Compare August 31, 2023 10:21
@kdeldycke
Copy link
Contributor Author

Conflicts have been resolved, this PR has been rebased on main.

It is ready to merged back for the upcoming Click 8.2.x.

@cthoyt
Copy link

cthoyt commented Oct 1, 2023

@kdeldycke I like this!

@AndreasBackx AndreasBackx added this to the 8.1.8 milestone Oct 26, 2024
@AndreasBackx AndreasBackx mentioned this pull request Oct 26, 2024
9 tasks
@AndreasBackx AndreasBackx self-assigned this Nov 2, 2024
@AndreasBackx AndreasBackx changed the base branch from main to stable November 2, 2024 14:36
@AndreasBackx AndreasBackx merged commit 26aa7bf into pallets:stable Nov 2, 2024
12 checks passed
@kdeldycke
Copy link
Contributor Author

Thanks @AndreasBackx for the merge! 🥳

@kdeldycke kdeldycke deleted the deduplicate-help-option branch November 2, 2024 14:49
@AndreasBackx
Copy link
Collaborator

Thank you for the PR @kdeldycke. Just trying to get through the backlog of issues and PR now so we can get some more movement on the project. 😃

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants