Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colored output on Windows (#2606) #2607

Merged

Conversation

krisztianloki
Copy link
Contributor

@krisztianloki krisztianloki commented Sep 5, 2023

The color parameter of echo() was not passed to the auto_wrap_for_ansi() function that is used to wrap a stream with colorama on Windows. This PR fixes that.
I did not add an entry to CHANGES.rst because there is no 8.1.8dev version yet

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@AndreasBackx AndreasBackx added this to the 8.1.8 milestone Oct 26, 2024
@AndreasBackx AndreasBackx mentioned this pull request Oct 26, 2024
7 tasks
@AndreasBackx AndreasBackx force-pushed the fix-forcing-color-output-on-windows branch from 2c67ebd to 2fba1b4 Compare October 26, 2024 13:02
@AndreasBackx AndreasBackx changed the base branch from stable to main October 26, 2024 13:04
@AndreasBackx AndreasBackx force-pushed the fix-forcing-color-output-on-windows branch from 2fba1b4 to 46d1673 Compare October 26, 2024 13:21
@AndreasBackx AndreasBackx changed the base branch from main to stable October 26, 2024 13:22
@AndreasBackx AndreasBackx merged commit afc86c7 into pallets:stable Oct 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants