Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specialize progressbar(length=...) as ProgressBar[int] #2630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

specialize progressbar(length=...) as ProgressBar[int] #2630

wants to merge 1 commit into from

Conversation

asottile
Copy link

@asottile asottile commented Nov 7, 2023 •
edited
Loading

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code. N/A
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@asottile asottile marked this pull request as ready for review November 7, 2023 22:06
asottile
asottile commented Nov 7, 2023
View reviewed changes
tests/typing/typing_progressbar.py
Comment on lines +14 to +15
def it() -> tuple[str, ...]:
return ("hello", "world")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this separate function is entirely so pyright doesn't inference as Literal[("hello", "world")]

@asottile
Copy link
Author

asottile commented Feb 4, 2024

I hate being that guy but I noticed this PR sticking around when I went to clean up some repos -- is there anything left here?

@davidism
Copy link
Member

davidism commented Feb 4, 2024

It's good, just haven't had a chance to go through the click backlog in quite a while.

@aenglander aenglander added this to the 8.1.8 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidism davidism davidism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@asottile @davidism @aenglander