-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to hide the progress bar Issue #2609 #2727
Conversation
I know I was uncertain about this at the sprint, but after some thought I'm good with it. Simon also mentioned in the issue that it might be possible to just set the |
I've looked over the code related to the self.is_hidden property. Modifying that is likely the better way to go since it will still handle what to do with the self.file text stream. I'll make the needed changes. Also, should we change is_hidden to _is_hidden? It behaves like a property that's private to the object. |
Sounds good. If the attribute is not documented in the public documentation, then it can be renamed without a deprecation first. |
I ended up having issues for the test related to this feature and had to separate the logic for self.hidden and self._is_hidden. It's probably easier to follow anyway. Should be good to go. |
… environment as env)
8ae3ef8
to
75bd9d7
Compare
…e confusion with `ProgressBar.hidden`. Clarified CHANGES.
fixes #2609