Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working from Windows for a change, so why not fix some of the typing here?
This makes it so running the type checks on all platforms no longer gives any errors. Additionally,
tox.ini
has been updated to make sure it runs all tests on all platforms. This will do some extra work and make things slower unfortunately. I think if we move touv
in the future, we can make this faster (from having a short glance at some information I saw online). One can also runtox
in parallel, though for some reason you cannot seem to enable that from the config.Add tests that demonstrate the correct behavior of the change. Testsshould fail without the change.
Add an entry in CHANGES.rst summarizing the change and linking to the issue.Add.. versionchanged::
entries in any relevant code docs.