Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] The int filter throws OverflowError for scientific notation #1984

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from
Open

[Fix] The int filter throws OverflowError for scientific notation #1984

wants to merge 3 commits into from

Conversation

flpm
Copy link

@flpm flpm commented May 20, 2024

What was done:

  • handle the case where a string passed to the int filter would cause an OverflowError when float() is called. E.g. '1e100000.
  • add a new test case to test_int()
  • add entry in CHANGES.rst

fixes #1921

@flpm flpm marked this pull request as draft May 20, 2024 15:18
@davidism
Copy link
Member

git rebase --onto origin/3.1.x origin/main then git push -f

@flpm flpm force-pushed the issue-1291-int-throws-overflowerror branch from 1d98726 to cc97ac3 Compare May 20, 2024 15:32
@flpm flpm marked this pull request as ready for review May 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flpm @davidism