[Step 1 of 2] feat: add create2Factory #1
Conversation
ChefMist
changed the title
ChefMist
changed the title
|
ready for review, no more change will be added |
| nonReentrant | ||
| returns (address deployed) | ||
| { | ||
| deployed = Create2.deploy(msg.value, salt, creationCode); |
There was a problem hiding this comment.
Suggestion： can we add deploy event here , so we can know which contract deployed by this factory
chefburger
force-pushed
the
feat/add-create2-factory
branch
from
ee79f71 to
d77c1c3
Compare
src/CustomizedProxyChild.sol
Outdated
|
|
||
| if (newOwner != address(0)) { | ||
| // transfer ownership | ||
| Ownable(addr).transferOwnership(newOwner); |
There was a problem hiding this comment.
I think the only issue with this is what if the addr is not Ownable? like if it is IAccessControl?
There was a problem hiding this comment.
i guess then we might need to have a separate ProxyChild for that contract. In my sense the "ProxyChild" is more like a on-chain "deployScript" with fixed addr and nonce = 0. It needs to be customized according to the contract we want to deploy
There was a problem hiding this comment.
then maybe we can just generalized it by deploy(creationCode, calldata) and then addr.call(calldata)
There was a problem hiding this comment.
will update this part if this approach is taken
There was a problem hiding this comment.
same thoughts, agree with Omelette since some of his farming contract is not using Ownable 😆
src/Create3.sol
Outdated
| //SPDX-License-Identifier: Unlicense | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| import {CustomizedProxyChild} from "./CustomizedProxyChild.sol"; |
There was a problem hiding this comment.
would there also be a Create3Factory.sol ?
src/Create3.sol
Outdated
| // TODO: update desc | ||
|
|
||
| /** | ||
| * @title A library for deploying contracts EIP-3171 style. |
There was a problem hiding this comment.
maybe can put the reference to where this was 'referenced' from
chefburger
force-pushed
the
feat/add-create2-factory
branch
from
d77c1c3 to
f6a5133
Compare
Based on option 2c
This is a 2 steps process:
Original goal: have all deployment script here. However we cannot do that as this means all contract will deploy from the same
foundry.tomlconfig