Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Remove redundant rerender in match breakpoint provider #10285

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

perf: Remove redundant rerender in match breakpoint provider #10285

wants to merge 2 commits into from
+1 −3

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jul 28, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR addresses compatibility with Safari versions earlier than 14 by using optional chaining for the addEventListener method. It also removes an unnecessary state update in the MatchBreakpointsProvider component.

Detailed summary

  • Updated the conditional check for mql.addEventListener to use optional chaining (mql?.addEventListener).
  • Removed the line that sets state with getBreakpointChecks(getState()) in the MatchBreakpointsProvider component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel Vercel
Copy link

vercel bot commented Jul 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:48am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 299bdba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

memoyil
memoyil commented Jul 28, 2024
View reviewed changes
packages/uikit/src/contexts/MatchBreakpoints/Provider.tsx
@@ -112,8 +112,6 @@ export const MatchBreakpointsProvider: React.FC<React.PropsWithChildren> = ({ ch
};
});

setState(getBreakpointChecks(getState()));
Copy link
Collaborator Author

@memoyil memoyil Jul 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed since it is done in initial state too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have u try with SSR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nft pages are generated by ssr, and it works correctly without flashing first

https://web-git-feature-perfremoveredundantrerenderinmatchbreakpoint.pancake.run/nfts/collections/0x4bd2a30435e6624ccdee4c60229250a84a2e4cd6/7279

@memoyil memoyil force-pushed the feature/perf_remove_redundant_rerender_in_match_breakpoint branch from 43c5e41 to afbd01a Compare August 13, 2024 07:59
@memoyil memoyil force-pushed the feature/perf_remove_redundant_rerender_in_match_breakpoint branch from afbd01a to 5db124e Compare August 19, 2024 12:22
@memoyil memoyil force-pushed the feature/perf_remove_redundant_rerender_in_match_breakpoint branch from 5db124e to 299bdba Compare September 27, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjojoex 0xjojoex Awaiting requested review from 0xjojoex

@ChefMomota ChefMomota Awaiting requested review from ChefMomota ChefMomota is a code owner

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi Chef-Yogi is a code owner

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@ChefBingbong ChefBingbong Awaiting requested review from ChefBingbong

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@memoyil @ChefJerry