Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the tokenList cache in universal pages #10753

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

chef-eric
Copy link
Contributor

@chef-eric chef-eric commented Sep 28, 2024

PR-Codex overview

This PR adds a new constant for universal page paths and integrates it into the UpdaterByChainId function to enhance routing checks.

Detailed summary

  • Introduced UNIVERSAL_PAGE_PATHS with paths for liquidity pools and positions in exchange.ts.
  • Updated the import statement in updater.ts to include UNIVERSAL_PAGE_PATHS.
  • Modified the includeListUpdater logic to check against both EXCHANGE_PAGE_PATHS and UNIVERSAL_PAGE_PATHS.
  • Adjusted the queryKey in the useQuery hook to include chainId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 28, 2024

⚠️ No Changeset found

Latest commit: e1d4288

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web 🛑 Canceled (Inspect) Sep 30, 2024 2:13am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:13am
blog ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:13am
bridge ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:13am
games ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:13am
gamification ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:13am
uikit ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:13am

@chefjackson chefjackson merged commit 8a9a54d into develop Sep 30, 2024
20 checks passed
@chefjackson chefjackson deleted the fix/token-list-cache branch September 30, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants