Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Web3 inbox account error #10788

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 6, 2024

image


PR-Codex overview

This PR updates the useInitializeNotifications hook to handle the case where address might be undefined when calling useWeb3InboxAccount. It ensures that the account data is fetched correctly only if an address is provided.

Detailed summary

  • Modified the useWeb3InboxAccount call to check if address is defined.
  • If address is undefined, it passes undefined to useWeb3InboxAccount instead of constructing the string.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 6, 2024

⚠️ No Changeset found

Latest commit: 124aa9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 8:37am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Oct 6, 2024 8:37am
blog ⬜️ Ignored (Inspect) Oct 6, 2024 8:37am
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 8:37am
games ⬜️ Ignored (Inspect) Oct 6, 2024 8:37am
gamification ⬜️ Ignored (Inspect) Oct 6, 2024 8:37am
uikit ⬜️ Ignored (Inspect) Oct 6, 2024 8:37am

@ChefMomota ChefMomota merged commit b646a2d into develop Oct 7, 2024
20 checks passed
@ChefMomota ChefMomota deleted the feature/fix_web3_inbox_account_error branch October 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants