Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trading view chart locale #11136

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 14, 2025

Fixes chinese locales that doesn't work for tw chart right now


PR-Codex overview

This PR focuses on modifying the handling of the locale variable in the initializeTradingView function to improve locale formatting by replacing hyphens with underscores and converting the latter part to uppercase.

Detailed summary

  • Added a new locale variable initialized with localeCode.
  • Updated the locale variable to replace hyphens with underscores and capitalize the latter part if localeCode contains a hyphen.
  • Changed the locale parameter in the initializeTradingView function call from localeCode to the new locale variable.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: 098ecb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:51am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Jan 14, 2025 9:51am
blog ⬜️ Ignored (Inspect) Jan 14, 2025 9:51am
bridge ⬜️ Ignored (Inspect) Jan 14, 2025 9:51am
games ⬜️ Ignored (Inspect) Jan 14, 2025 9:51am
gamification ⬜️ Ignored (Inspect) Jan 14, 2025 9:51am
uikit ⬜️ Ignored (Inspect) Jan 14, 2025 9:51am
ton ⬜️ Skipped (Inspect) Jan 14, 2025 9:51am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant