Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add workaround for wrong translations #11157

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 21, 2025

Some translations have problem with placeholders

https://github.com/pancakeswap/pancake-frontend/blob/develop/locales/fr-FR.json#L3439

which causes

image


PR-Codex overview

This PR focuses on improving regex handling for variable substitutions in the Provider.tsx file, enhancing the matching logic for translated text and adding a fallback regex for data keys.

Detailed summary

  • Changed includesVariableRegex from global ('gm') to multiline ('m') mode.
  • Updated translatedTextIncludesVariable to use test method instead of match.
  • Added getFallbackRegExpForDataKey to support optional whitespace in data key regex.
  • Enhanced the replacement logic to fallback to the new regex if the initial replacement does not change the result.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: fcc786b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 0:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Skipped (Inspect) Jan 21, 2025 0:58am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant