Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove old swap & liquidity code #11181

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 8, 2025


PR-Codex overview

This PR focuses on the removal of various files and components related to the Swap and V3Swap functionalities, streamlining the codebase by consolidating hooks and utilities under a unified structure.

Detailed summary

  • Deleted multiple files in apps/web/src/views/Swap and apps/web/src/state/swap.
  • Removed SwapPage component, replacing it with an empty fragment.
  • Updated import paths for hooks and utilities to a new structure.
  • Consolidated types and enums in apps/web/src/views/Swap/types.ts.
  • Adjusted components in SwapSimplify to use the new import paths.
  • Removed unused components and hooks to clean up the codebase.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: 816fc48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 5:29pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:29pm
blog ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:29pm
bridge ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:29pm
games ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:29pm
gamification ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:29pm
uikit ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 5:29pm
ton ⬜️ Skipped (Inspect) Feb 19, 2025 5:29pm

Copy link
Collaborator Author

@memoyil memoyil Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

barrel exports prevents tree shaking

@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 09:44 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 09:45 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:34 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 10:40 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 15:01 Inactive
@memoyil memoyil changed the title refactor: Remove old swap code refactor: Remove old swap&liquidity code Feb 8, 2025
@memoyil memoyil changed the title refactor: Remove old swap&liquidity code refactor: Remove old swap & liquidity code Feb 8, 2025
@memoyil memoyil force-pushed the feature/refactor_remove_old_swap_code branch from 2f710e2 to e2170fa Compare February 8, 2025 15:04
@vercel vercel bot temporarily deployed to Preview – ton February 8, 2025 15:04 Inactive
@memoyil memoyil force-pushed the feature/refactor_remove_old_swap_code branch from e123557 to 9f178fc Compare February 12, 2025 11:54
@vercel vercel bot temporarily deployed to Preview – ton February 12, 2025 11:54 Inactive
@vercel vercel bot temporarily deployed to Preview – ton February 12, 2025 12:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant