Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Killed gauges display problem ; reduce the ttl for cache by lru #11196

Merged
merged 21 commits into from
Feb 17, 2025

Conversation

chef-ryan
Copy link
Contributor

@chef-ryan chef-ryan commented Feb 12, 2025


PR-Codex overview

This PR introduces several enhancements and fixes across various packages, including the addition of quick-lru for caching, updates to the TableRow component for displaying deleted gauges, and improvements in API response handling.

Detailed summary

  • Added quick-lru dependency for caching.
  • Updated TableRow to display a "Deleted" status for killed gauges.
  • Modified useGauges to accept a showKilled parameter.
  • Implemented caching for gauge fetching functions.
  • Adjusted cache settings in API handlers.
  • Refined gauge data merging logic in getAllGauges.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Ignored (Inspect) Feb 17, 2025 9:59am

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: b45a20b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – ton February 12, 2025 15:51 Inactive
@chef-ryan chef-ryan changed the title fix: 🐛 fix cache issues of gauges fix: 🐛 Reduce the cache ttl to 10-20s for gauge list Feb 12, 2025
@chef-ryan chef-ryan force-pushed the fix/gauge-voting-feb-12 branch from c983139 to 8a84750 Compare February 12, 2025 16:19
@chef-ryan chef-ryan merged commit 49764a3 into develop Feb 17, 2025
20 checks passed
@chef-ryan chef-ryan deleted the fix/gauge-voting-feb-12 branch February 17, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants