Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ismetamask private field crash #11212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 16, 2025


PR-Codex overview

This PR focuses on enhancing the error handling and checking logic for detecting MetaMask in the window.ethereum object within two files: apps/web/src/config/wallet.ts and apps/gamification/config/wallet.ts.

Detailed summary

  • Wrapped the detection logic in a try-catch block to handle potential errors.
  • Changed the check for isMetaMask to explicitly compare it to true.
  • Updated the check for providers to ensure it's an array before calling some.
  • Added error handling within the some method to catch exceptions for each provider.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 16, 2025

⚠️ No Changeset found

Latest commit: a83650a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 1:55pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 1:55pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2025 1:55pm
blog ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2025 1:55pm
bridge ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2025 1:55pm
games ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2025 1:55pm
uikit ⬜️ Ignored (Inspect) Visit Preview Feb 16, 2025 1:55pm
ton ⬜️ Skipped (Inspect) Feb 16, 2025 1:55pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants