Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add quick input to roi calculator #6947

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented May 22, 2023

🤖 Generated by Copilot at 48b911a

Summary

📊🧹🔧

This pull request improves the user interface and code quality of the liquidity chart range input component, which is used to add or remove liquidity to a pool. It imports and uses constants and types from the @pancakeswap/uikit package, removes unused code, and adds a quick action feature to the ROI calculator widget.

To make the liquidity chart more robust
We imported some constants we trust
From the uikit package
We got rid of some baggage
And added a feature for zoom and adjust

Walkthrough

  • Move ZOOM_LEVELS and QUICK_ACTION_CONFIGS constants from local files to @pancakeswap/uikit package and rename them to LIQUIDITY_ZOOM_LEVELS and LIQUIDITY_QUICK_ACTION_CONFIGS for consistency (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add optional chaining operators to multiply method calls on maxAmounts objects in V3FormView component to prevent errors if they are undefined (link, link)
  • Add activeQuickAction state variable and handleRefresh function to RoiCalculator component to enable quick action buttons and full range button for price range chart (link, link, link)
  • Remove unused imports of FeeAmount and ZoomLevels types from local files (link, link)
  • Import FeeAmount type from @pancakeswap/v3-sdk package in @pancakeswap/uikit package (link)

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

⚠️ No Changeset found

Latest commit: 1afc50f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 11:59pm
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 11:59pm
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 11:59pm
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 11:59pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 11:59pm

@vercel
Copy link

vercel bot commented May 22, 2023

@memoyil is attempting to deploy a commit to the PancakeSwap Team on Vercel.

A member of the Team first needs to authorize it.

@memoyil memoyil force-pushed the feature/feat_add_quick_input_to_roi_calculator branch from 48b911a to 94dbb7e Compare May 22, 2023 01:56
@memoyil memoyil force-pushed the feature/feat_add_quick_input_to_roi_calculator branch from 94dbb7e to 6701d97 Compare May 26, 2023 18:59
@memoyil memoyil force-pushed the feature/feat_add_quick_input_to_roi_calculator branch from 6701d97 to 6035b5a Compare May 29, 2023 08:59
@memoyil memoyil force-pushed the feature/feat_add_quick_input_to_roi_calculator branch from 6035b5a to 1c8a4bd Compare June 2, 2023 07:51
@chefjackson
Copy link
Collaborator

Close for now as it's stale. Feel free to reopen after updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants