You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull request enhances the performance and user experience of the CurrencySearchModal component by memoizing its configuration and moving it to a more appropriate app folder. It also simplifies the useState hook for the duration state in the useLockedPool hook.
We search for the currency of doom We memoize the modal of despair We simplify the state of our fate We optimize the code of our resistance
Walkthrough
Optimize the rendering of the config object in the CurrencySearchModal component by wrapping it in a useMemo hook with the dependencies t and prevView (link, link, link, link)
Move the CurrencySearchModal component from apps/web/src/components/SearchModal to apps/aptos/components/SearchModal as part of a refactoring of the project structure to separate the web and aptos apps (link)
Simplify the useState hook for the duration state in the useLockedPool hook by using the defaultDuration value directly instead of a function that returns it (link)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memoyil
requested review from
0xjojoex,
ChefMomota,
chefilip,
Chef-Yogi and
chefjackson
as code owners
🤖 Generated by Copilot at 6d1d9c8
Summary
📝🚀🚚
The pull request enhances the performance and user experience of the
CurrencySearchModalcomponent by memoizing its configuration and moving it to a more appropriate app folder. It also simplifies theuseStatehook for thedurationstate in theuseLockedPoolhook.Walkthrough
configobject in theCurrencySearchModalcomponent by wrapping it in auseMemohook with the dependenciestandprevView(link, link, link, link)CurrencySearchModalcomponent fromapps/web/src/components/SearchModaltoapps/aptos/components/SearchModalas part of a refactoring of the project structure to separate the web and aptos apps (link)useStatehook for thedurationstate in theuseLockedPoolhook by using thedefaultDurationvalue directly instead of a function that returns it (link)