Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple MM for mm linked pool #7177

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

Chef-Yogi
Copy link
Contributor

@Chef-Yogi Chef-Yogi commented Jun 20, 2023

🤖 Generated by Copilot at 80068c3

Summary

🧪🌐🔑

Modified some files to test and support the linked-pool feature, which allows users to swap tokens with market makers. Changed the API endpoint, added a second signer address, and matched the signer address with the market maker ID.

Walkthrough

  • Modify API_ENDPOINT to use test URL for quote-service (link)
  • Add second signer address for BSC chain to support multiple market makers (link)
  • Use matching mmSigner address for swap transaction based on rfq.mmId parameter (link)

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: d06c67f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 9:49am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Jul 6, 2023 9:49am
blog ⬜️ Ignored (Inspect) Jul 6, 2023 9:49am
bridge ⬜️ Ignored (Inspect) Jul 6, 2023 9:49am
uikit ⬜️ Ignored (Inspect) Jul 6, 2023 9:49am

@@ -9,7 +9,7 @@ import {
MessageType,
} from '../types'

const API_ENDPOINT = process.env.NEXT_PUBLIC_MM_API_URL
const API_ENDPOINT = `https://test.linked-pool.pancakeswap.com/quote-service` || process.env.NEXT_PUBLIC_MM_API_URL // TODO: remove the test one after test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a prod endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this change is just for testing purposes, will remove https://test.linked-pool.pancakeswap.com/quote-service after BE deploy the following changes to process.env.NEXT_PUBLIC_MM_API_URL

@chefjackson chefjackson merged commit d1a3bbe into develop Jul 6, 2023
11 checks passed
@chefjackson chefjackson deleted the feat/support-multiple-MM-for-MM-linked-pools branch July 6, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants