Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New trading reward UI #7296

Merged
merged 10 commits into from
Jul 10, 2023

Conversation

ChefMomota
Copy link
Contributor

@ChefMomota ChefMomota commented Jul 5, 2023

🤖 Generated by Copilot at 8d25515

Summary

🏆🔄📱

This pull request adds features to the TradingReward view and its components to show multiple rounds of the trading competition leaderboard and rewards breakdown. It also refactors and improves the data fetching, rendering, and layout logic of the components. It updates the useUserTradeRank hook to return more user rank data and a loading indicator. It removes unused props and translations and adds new translations for the new features.

Leaderboard of doom, show me the ranks of the best
RewardsBreakdown of despair, reveal the prizes of the rest
MyRank of hope, inspire me to rise and compete
useUserTradeRank of power, load the data and make it complete

Walkthrough

  • Add new features to the Leaderboard and the RewardsBreakdown components to allow the user to switch between the current and previous rounds of the leaderboard and the rewards breakdown and show the round information for each round (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)
  • Create a new component called MyRank, which displays the user's own rank separately from the top 50 users, and use it in the Leaderboard component (link,link)
  • Modify the useUserTradeRank hook to return more properties of the user's rank data and an isFetching property to indicate the loading state (link,link,link)
  • Modify the Leaderboard and the RewardsBreakdown components to handle the loading state and the undefined data more gracefully (link,link,link,link,link,link,link,link,link,link,link)
  • Modify the table headers and the layout of the Leaderboard component to simplify the table and match the design of the mobile view (link,link,link)
  • Modify the CurrentPeriod component of the YourTradingReward component to destructure the data and the isFetching properties from the useUserTradeRank hook (link)
  • Remove some unused props and translations from the RewardsBreakdown and the Leaderboard components (link,link,link,link,link,link)

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

⚠️ No Changeset found

Latest commit: 73a006a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 5:26am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
uikit ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 5:26am

@vercel
Copy link

vercel bot commented Jul 5, 2023

@ChefMomota is attempting to deploy a commit to the PancakeSwap Team on Vercel.

A member of the Team first needs to authorize it.

Chef-Yogi
Chef-Yogi previously approved these changes Jul 10, 2023
chefjackson
chefjackson previously approved these changes Jul 10, 2023
@ChefMomota ChefMomota merged commit 09e7ead into pancakeswap:develop Jul 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants