fix: Wrong v2 token order on pair detail page causes incorrect balance displayed #7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
0xjojoex,
ChefMomota,
chefilip,
Chef-Yogi and
chefjackson
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@memoyil is attempting to deploy a commit to the PancakeSwap Team on Vercel. A member of the Team first needs to authorize it. |
chefjackson
approved these changes
Jul 7, 2023
memoyil
deleted the
feature/fix_wrong_v2_order_pairs_results_wrong_balance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce
Go to https://pancakeswap.finance/find
Try v2 pair that account have with opposite pair order
Click manage pair button
See token balances flipped and incorrect amount shown
🤖 Generated by Copilot at a4aaf68
Summary
🗑️♻️🛠️
This pull request refactors the liquidity and pair pages to use a common
pairobject that contains the relevant data for each pair. It also improves the code style, fixes a broken link, and removes an unused code block.Walkthrough
pairobject as the source of truth instead of individual currency variables (link, link, link, link, link, link, link, link, link)apps/web/src/pages/liquidity/index.tsxfile (link)apps/web/src/views/PoolFinder/index.tsxfile to use relative paths and reorder them by type and alphabetically (link)