Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MM linked pool doc adjustment #7324

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

Chef-Yogi
Copy link
Contributor

@Chef-Yogi Chef-Yogi commented Jul 10, 2023

🤖 Generated by Copilot at 4a60802

Summary

🔄🌐🔗

This pull request adds support for variable fees and different external links for market maker trades in the Swap view. It also updates the English translation file to match the new text strings.

Swap fees vary now
TradeSummary shows more links
Autumn of changes

Walkthrough

  • Add conditional logic to external link for fee breakdown and tokenomics documentation based on market maker pool usage (link)
  • Update implied fee range text for non-stablecoin trades from market makers to reflect variable fee structure (link, link, link)
  • Modify TradeSummary component to display updated fee information in both SwapModalFooter and AdvancedSwapDetails components (link, link, link)

@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 7:07am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 7:07am
blog ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 7:07am
bridge ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 7:07am
uikit ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2023 7:07am

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

⚠️ No Changeset found

Latest commit: 42c9629

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Chef-Yogi Chef-Yogi merged commit 299cd2b into develop Jul 10, 2023
11 checks passed
@Chef-Yogi Chef-Yogi deleted the chore/MM-linked-pool-doc-adjustment branch July 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants