Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust test for slice due to typeshed changes #1067

Merged
merged 2 commits into from
Dec 2, 2024
Merged

adjust test for slice due to typeshed changes #1067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0edda9d
adjust test for slice due to typeshed changes
Dr-Irv Dec 2, 2024
3a2a2fa
comment out the previous test
Dr-Irv Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,7 +2398,14 @@ def test_indexslice_getitem():
.set_index(["x", "y"])
)
ind = pd.Index([2, 3])
check(assert_type(pd.IndexSlice[ind, :], tuple["pd.Index[int]", slice]), tuple)
# This next test is written this way to support both mypy 1.13 and newer
# versions of mypy and pyright that treat slice as a Generic due to
# a change in typeshed.
# Once pyright 1.1.390 and mypy 1.14 are released, the test can be
# reverted to the standard form.
# check(assert_type(pd.IndexSlice[ind, :], tuple["pd.Index[int]", slice]), tuple)
tmp: tuple[pd.Index[int], slice] = pd.IndexSlice[ind, :]
check(assert_type(tmp, tuple["pd.Index[int]", slice]), tuple)
check(assert_type(df.loc[pd.IndexSlice[ind, :]], pd.DataFrame), pd.DataFrame)
check(assert_type(df.loc[pd.IndexSlice[1:2]], pd.DataFrame), pd.DataFrame)
check(
Expand Down
Loading