-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added horizontal scrolling functionality #52
base: main
Are you sure you want to change the base?
Conversation
Hello @maha-sachin ! That's a good start! Thanks for opening the draft PR! I think you should not be modifying With regards to combining My suggestion for you now would be to just clean up this PR, and rebase on top of the last changes on main! |
Thank you for your feedback and guidance on the draft PR. I apologize for the delayed response, as I have been feeling unwell recently. I will do it as soon as possible. Thank you for your understanding and support. |
Hi @Julow @panglesd , As per your suggestion, I started by implementing the horizontal scroll area functionality, which is working as expected. However, I'm now facing difficulties in combining both vertical and horizontal scroll areas within the same current hunk.
I've thoroughly tested each scroll area separately, and they work fine individually. However, when I attempt to integrate them into the same current hunk, I'm encountering issues.
I believe that understanding the correct approach to combine both vertical and horizontal scroll areas will greatly benefit the overall usability and functionality of the current hunk display.
Could you please provide some guidance or suggestions on how to effectively combine both scroll areas within the same current hunk? Any insights or examples you can provide would be immensely helpful in overcoming this hurdle.
Additionally, I've prepared a draft pull request with my current progress for your review. While it's not yet complete due to the challenge above, I'd appreciate any feedback or suggestions you may have on my hscroll_area implementation.I look forward to your guidance and feedback.