Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbered lines for side by side view #63

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Numbered lines for side by side view #63

merged 8 commits into from
Jun 27, 2024

Conversation

yokurang
Copy link
Collaborator

No description provided.

@yokurang yokurang requested review from panglesd and Julow and removed request for panglesd June 19, 2024 12:04
@yokurang
Copy link
Collaborator Author

image

Julow
Julow reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome :) I've left many questions in the code but the feature works perfectly.

lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
lib/interactive_viewer.ml Outdated Show resolved Hide resolved
@yokurang yokurang requested a review from Julow June 25, 2024 16:10
Julow
Julow approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
Before merging, it would be nice to showcase more complex cases in the tests, like the operation 4 in example.diff: removals with no added lines, added lines with no removals.

Julow
Julow approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's merge once the CI is green.

@yokurang yokurang merged commit dc9a8da into panglesd:main Jun 27, 2024
2 checks passed
@yokurang yokurang deleted the numbered-lines branch June 27, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yokurang @Julow