-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards word diffing #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the Patch.t type to contain richer data for lines than strings. Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
This module contains an alternative representation of changes that is more suitable for the split view and the word diffing. Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
This module is used to add word level information in diffs. Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
panglesd
commented
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Could you add a test? Also, you decide to represent the mine and their lines of a block in the reverse order, which is in my opinion counter-intuitive!
We might want to change the interface a little bit, to avoid the mine_start
field.
* first draft * forgot to format * matching implementation * matching implementation * matching implementation * forward and backward function * implement midpoint and find path * rough and dirty draft -> to discuss algorithm for word-diff * some refactoring and implementation: * something that barely works * word level diff, TODO refactoring: * abstract out process line for plug-and-pull later if necessary * refactoring complete * progress * progress * progres * some cleaning * cleaned * updated tests * added more tests * added more tests * modify api * cleaned * added logging: * moved new tests * cleaned up * cleaned up * cleaned up * cleaned up * cleaned up * clean up * added tests
Allows the Patch.t type to contain richer data for lines than strings. Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
This module contains an alternative representation of changes that is more suitable for the split view and the word diffing. Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
This module is used to add word level information in diffs. Signed-off-by: Paul-Elliot <[email protected]> Co-authored-by: Jules Aguillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a skeleton of functions and types that will be useful to implement word diffing.