bug: alleviate the data race between Release() and Reboot()

panjf2000 · Jun 17, 2024 · d5724a2 · d5724a2
1 parent da22980
commit d5724a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pool.go b/pool.go
@@ -135,9 +135,10 @@ func (p *Pool) ticktock() {
 		atomic.StoreInt32(&p.ticktockDone, 1)
 	}()
 
+	ticktockCtx := p.ticktockCtx // copy to the local variable to avoid race from Reboot()
 	for {
 		select {
-		case <-p.ticktockCtx.Done():
+		case <-ticktockCtx.Done():
 			return
 		case <-ticker.C:
 		}

diff --git a/pool_func.go b/pool_func.go
@@ -92,9 +92,10 @@ func (p *PoolWithFunc) ticktock() {
 		atomic.StoreInt32(&p.ticktockDone, 1)
 	}()
 
+	ticktockCtx := p.ticktockCtx // copy to the local variable to avoid race from Reboot()
 	for {
 		select {
-		case <-p.ticktockCtx.Done():
+		case <-ticktockCtx.Done():
 			return
 		case <-ticker.C:
 		}