Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: make ReleaseTimeout() more efficient in waiting workers to exit #329

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

panjf2000
Copy link
Owner

Also, this PR utilizes embedding structs to eliminate duplicate fields of Pool and PoolWithFunc.

@github-actions github-actions bot added the enhancement New feature or request label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.52%. Comparing base (3ffd3da) to head (b9e7aaf).

Files Patch % Lines
pool.go 85.36% 5 Missing and 1 partial ⚠️
pool_func.go 86.36% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #329      +/-   ##
==========================================
- Coverage   91.32%   90.52%   -0.81%     
==========================================
  Files          11       11              
  Lines         761      802      +41     
==========================================
+ Hits          695      726      +31     
- Misses         45       53       +8     
- Partials       21       23       +2     
Flag Coverage Δ
unittests 90.52% <87.09%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 15e8961 into dev Jun 17, 2024
11 of 13 checks passed
@panjf2000 panjf2000 deleted the release-timeout branch June 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant