Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix the last error being missed in ReleaseTimeout() for multi-pool #334

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

panjf2000
Copy link
Owner

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (b40e489) to head (03cee03).

Files Patch % Lines
multipool.go 66.66% 0 Missing and 1 partial ⚠️
multipool_func.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #334      +/-   ##
==========================================
- Coverage   90.90%   90.77%   -0.14%     
==========================================
  Files          11       11              
  Lines         836      824      -12     
==========================================
- Hits          760      748      -12     
  Misses         51       51              
  Partials       25       25              
Flag Coverage Δ
unittests 90.77% <66.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panjf2000 panjf2000 merged commit 313f136 into dev Jun 18, 2024
11 of 13 checks passed
@panjf2000 panjf2000 deleted the multi-pool-fix branch June 18, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant