Faster thread local random for inserts #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids making use of a global lock. Slighlty faster in benchmarks, but for most cases construction time doesn't matter and is bottle necked on reading input anyway. benchstat master_gotip.bench fastrand_gotip.bench name old time/op new time/op delta Filter_Reset-4 2.58µs ± 4% 2.61µs ±13% ~ (p=0.841 n=5+5) Filter_Insert-4 37.8ns ± 7% 35.9ns ± 0% ~ (p=0.190 n=5+4) Filter_Lookup-4 37.7ns ± 6% 37.6ns ± 3% ~ (p=0.841 n=5+5)
|
Sorry I couldn't respond earlier. I'll resubmit a PR with the subset you requested in #13. I gotta say, though, personally I'd much sooner take another dependency than use Since this code already has go-metro, I could rework #13 to use that instead of wyhash to get the same result without a new dependency. If you're interested, I could have that done this weekend. |
|
You're bringing up some good points, the things that in the end swayed me towards runtime.fastrandn were
I hope that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid costly global random calls.