Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual Support added #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aannaassalam
Copy link

Hi, I have added the multilingual support to this Accounthill invoicing project here. Please check it once I hope you like it and appreciate my work.
This is a solution for issue #10. It supports the following languages: English, Spanish, French, Portuguese, Chinese, Hindi, Arabic, Urdu, Vietnamese, Turkish, Japanese, Greek, Indonesian, Italian, Russian, Korean, and German.

@netlify
Copy link

netlify bot commented Dec 27, 2022

👷 Deploy request for accountill pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 66795ba

@panshak
Copy link
Owner

panshak commented Dec 30, 2022

@aannaassalam great! I'll test your PR and merge if everything works well.

@panshak
Copy link
Owner

panshak commented Jan 28, 2023

I couldn't deploy your PR. Could you check and see what the problem is?

@aannaassalam
Copy link
Author

Is it running fine on local environment?

@panshak
Copy link
Owner

panshak commented Jan 28, 2023

Is it running fine on local environment?

I just checked now and it's not running locally. I got this error:

`ReferenceError: t is not defined
AddClient
C:/Users/E7470/Desktop/multi/client/src/components/Invoice/AddClient.js:142
139 | open={open}
140 | fullWidth
141 | >

142 | <DialogTitle
| ^ 143 | id="customized-dialog-title"
144 | onClose={handleClose}
145 | style={{ paddingLeft: "20px", color: "white" }}`

Can you check and ensure everything is working correctly so I can merge it?
Thanks.

@aannaassalam
Copy link
Author

aannaassalam commented Jan 28, 2023 via email

@panshak
Copy link
Owner

panshak commented Jan 28, 2023

Please cross-check the code. Looks like you're calling hooks outside the body of a function component

@aannaassalam
Copy link
Author

@panshak fixed it was a reference error, I was trying to call the hook without creating an instance.

@aannaassalam
Copy link
Author

Hi, Panshak have you got any update on this pull request...

@panshak
Copy link
Owner

panshak commented Mar 24, 2023

@aannaassalam, seems like your PR have a merge conflict. Allow me some time to figure this out or if you can check the main branch and see if you can fix it, that'll be helpful.

@SB212019
Copy link

Hello sir

@SB212019
Copy link

Can you help me to add your multilingual feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants