Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend Pantheon Secrets instead of Lockr #9247

Merged
merged 13 commits into from
Oct 9, 2024

Conversation

ccharlton
Copy link
Contributor

@ccharlton ccharlton commented Oct 9, 2024

Fixes #9200
Fixes #9190

Summary

Swapped out Lockr for Pantheon Secrets
Recommend Pantheon Secrets first, and private secrets.json file as an alternative

I kept the Lockr content for now but added deprecated warning to the top and the title

@ccharlton ccharlton added Source: Pantheor Contribution from within Pantheon, unspecified team Type: Quick Fix Issues that should be resolvable in a small PR labels Oct 9, 2024
@ccharlton ccharlton requested a review from a team as a code owner October 9, 2024 00:04
Swapped Lockr for Pantheon Secrets
@ccharlton
Copy link
Contributor Author

ccharlton commented Oct 9, 2024

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton
Copy link
Member

Thanks for kicking this pr off @ccharlton! I did an audit and added every occurance of Lockr I found across the repo to this PR, if you have time / interest to review my changes please do!

@jazzsequence can you review the following as part of this PR:

I kept the Lockr content for now but added deprecated warning to the top and the title

@rachelwhitton rachelwhitton removed the request for review from stevector October 9, 2024 21:30
@rachelwhitton rachelwhitton changed the title Update integrations doc: swap Lockr with Pantheon Secrets Recommend Pantheon Secrets instead of Lockr Oct 9, 2024
@jazzsequence
Copy link
Contributor

@rachelwhitton LGTM with the couple (minor) code style changes I suggested to the pantheon_get_secrets code blocks.

@rachelwhitton rachelwhitton merged commit 31f2728 into main Oct 9, 2024
8 of 11 checks passed
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9247-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Pantheor Contribution from within Pantheon, unspecified team Topic: Secrets Type: Quick Fix Issues that should be resolvable in a small PR
Projects
None yet
3 participants