[CMSP-486] Add is_solr_query filter #588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it's impossible to turn off Solr for specific types of searches. Another considered solution was to allow for $query->get( 'solr_integrate' ); to be set to false and have that overwrite the result of $query->is_search() but the filter seems like it would give more flexibility and be clearer in it's goal.
|
I created a ticket to look at this internally, thank you for the PR! |
|
I love this. +100 to more filters. |
|
@jazzsequence The ticket is: CMSP-486 |
$enabled seems clearer than $is_solr_query
|
I'd also love to have some control using this filter to exclude specific rest api requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's impossible to turn off Solr for specific types of searches.
Another considered solution was to allow for $query->get( 'solr_integrate' ); to be set to false and have that overwrite the result of $query->is_search() but the filter seems like it would give more flexibility and be clearer in it's goal.