Remove CircleCI and replace with GitHub Actions #16
Conversation
| @@ -17,18 +17,15 @@ touch $BASH_ENV | |||
| ) >> $BASH_ENV | |||
| source $BASH_ENV | |||
|
|
|||
| set -ex | |||
|
|
|||
| TERMINUS_PLUGINS_DIR=.. terminus list -n remote | |||
There was a problem hiding this comment.
Shouldn't we just remove Circle now that we have GitHub actions?
There was a problem hiding this comment.
This is still being used by GitHub Actions. You just commented where it's being used. :)
There was a problem hiding this comment.
Misread as .circleci/... 😊
| name: full-workspace | ||
| path: /terminus-plugin-test/plugin | ||
| - name: Setup environment | ||
| run: chmod +x ./.ci/set-up-globals.sh && ./.ci/set-up-globals.sh |
There was a problem hiding this comment.
Did you just copy this from Build Tools? I don't see the set-up-globals script.
There was a problem hiding this comment.
The directory was renamed from .circleci to .ci. To answer your question, I copied from terminus-rsync-plugin.
| - name: Install plugin | ||
| run: terminus self:plugin:install . | ||
| - name: Install SSH key | ||
| uses: shimataro/[email protected] |
There was a problem hiding this comment.
This is failing right now, presumably due to the lack of a secret. This plugin does not require a fixture site, so we have the deep philosophical question: should we set up testing fixtures for plugins that don't need them, just so that folks who copy the code have example test fixtures? There's some merit to that, but I'd say maybe we should just keep it simple and remove TERMINUS_TOKEN et. al. from these tests, and put them back in where needed.
There was a problem hiding this comment.
I'd comment stuff out in the ci.yml file. This way, it's still there for people to copy but it's not affecting this project. Maybe comment out the lines and add a comment that to enable people should add secret and uncomment?
There was a problem hiding this comment.
Will commenting make the tests pass though? Can't we just make universal test secrets that are limited in scope to only testing repos?
There was a problem hiding this comment.
Commenting those sections in this specific plugin will make it pass because this plugin tests don't need those secrets
There was a problem hiding this comment.
The ssh-key-action is failing in GitHub actions.
There was a problem hiding this comment.
We could just set the secrets everywhere if we want the example here for reference.
There was a problem hiding this comment.
How do we plan on solving the ssh/secrets bottleneck?
This should be a pattern for all other plugins so we need to get this right.